Restore shift click behavior for search button opening as a popup #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
jamesmaa
approved these changes
May 13, 2024
| */ | ||
| async _onCommandOpenSettingsPage(params) { | ||
| /** @type {'existingOrNewTab'|'newTab'} */ | ||
| /** @type {'existingOrNewTab'|'newTab'|'popup'} */ | ||
| let mode = 'existingOrNewTab'; |
There was a problem hiding this comment.
Do you want to make mode an enum in this PR or separate?
There was a problem hiding this comment.
Can make another pr for that later.
Unsure, I tried bisecting but ended up with 8 commits. 1 bad and 1 good on each side and 6 in the middle which were completely broken and the extension didn't function for testing. It was in the middle of some massive refactoring so no way to really know. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515
It isn't obvious from the code changes but this is what is going on here:
Old behavior:
This all happens instantly so the popup search is never seen.
New behavior: