-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onyomi-hiragana handlebars #960
Conversation
* Add onyomi-hiragana handlebars * Add docs * Fix typo in documentation of kunyomi/onyomi handlebars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to npm run test:unit:write
to update the tests with the new handlebar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to set the version from 35 to 36 in test/options-util.test.js
in this area of the file:
profileCurrent: 0,
version: 35,
global: {
database: {
prefixWildcardsSupported: false
}
}
Co-authored-by: StefanVukovic99 <stefanvukovic44@gmail.com> Signed-off-by: rhgg2 <richard.garner@mq.edu.au>
* Update tests for onyomi-hiragana handlebars * Fix typo in code
Thanks for the feedback - I think everything should be in order now with the tests. |
This pull request adds an
onyomi-hiragana
handlebars to the Anki card templates. It does exactly what it says.I also found a typo in the documentation of the existing onyomi/kunyomi handlebars (hiragana and katakana are inverted).
I have made what I hope are all the necessary changes, except that I have not touched anything in the
test
directory.