Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

학생용 이메일이 아닐때 리다이렉트 설정 #94

Merged
merged 1 commit into from
Dec 4, 2023
Merged

학생용 이메일이 아닐때 리다이렉트 설정 #94

merged 1 commit into from
Dec 4, 2023

Conversation

hajeu
Copy link
Collaborator

@hajeu hajeu commented Dec 4, 2023

개요

학생용 이메일이 아닐경우에 특정 주소로 리다이렉트 되도록 추가하였습니다.

본문

oauthService에서 HttpServletResponse를 의존하고 있어서 추후에 리펙터링이 필요해 보입니다.

YangSiJun528
YangSiJun528 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@YangSiJun528 YangSiJun528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring Security에선 인증이 성공/실패했을 때, 실행되는 핸들러가 존재합니다.
리다이렉트, 에러 예외처리 등은 이러한 핸들러에 위치하는 것이 객체의 역할에 맞다고 생각합니다.

hotfix니까 일단은 approve 하겠지만, 바로 리팩토링 진행하고 다음 릴리즈에서 반영하는게 좋을 것 같네요.

@hajeu hajeu merged commit 205d3c3 into develop Dec 4, 2023
1 check passed
@hajeu hajeu deleted the hotfix/not-school-account branch December 5, 2023 00:31
@hajeu hajeu mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangSiJun528 YangSiJun528 YangSiJun528 approved these changes

@SungGil-5125 SungGil-5125 Awaiting requested review from SungGil-5125

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hajeu @YangSiJun528