Feature/modelmapper migration #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeonjyan
added
build success
siwony
requested changes
Dec 25, 2021
src/main/java/com/moment/the/improvement/service/ImprovementService.java
Show resolved
Hide resolved
siwony
approved these changes
Dec 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한 일
improvementService: exception 터지는 조건 if 조건으로 처리. (명확히 명시)junit5메서드를 골고루 활용 함.개선이 필요해 보이는 부분
참고
Exception Handling 부분에 대한 검증 누락.
Admin 로직 개편 | Test 작성 규칙 의논 후 검증 예정.
리뷰