Feat/add to cart #21
Merged
Feat/add to cart #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuvCharles
force-pushed
the
feat/get-cart
branch
from
6b369db
to
ed42631
Compare
DuvCharles
force-pushed
the
feat/add-to-cart
branch
from
4cf720b
to
45c1b67
Compare
DuvCharles
force-pushed
the
feat/add-to-cart
branch
from
45c1b67
to
39f899d
Compare
skpn
reviewed
Nov 21, 2023
| @@ -12,7 +12,10 @@ export const normalizeProduct = (product: SyliusProduct): Product => ({ | |||
| title: product.name, | |||
| description: product.shortDescription | |||
| }, | |||
| variants: product.variants.map((variant) => normalizeProductVariant(variant)), | |||
| // dont need varaints when serializing fort cart | |||
There was a problem hiding this comment.
typos (on peut laisser si on s'en fout mais je remonte au cas où)
variants not needed for cart
| variants: product.variants.map((variant) => normalizeProductVariant(variant)), | ||
| // dont need varaints when serializing fort cart | ||
| variants: product.variants | ||
| ? product.variants.map((variant) => normalizeProductVariant(variant)) |
There was a problem hiding this comment.
product.variants.map(normalizeProductVariant) ?
| syliusRequest(REST_METHODS.PUT, `/orders/${cartId}/items`, payload[0]); | ||
| return {}; | ||
| export const addToCart = async (cartId: string | undefined, payload: AddToCartPayload[]) => { | ||
| await syliusRequest(REST_METHODS.POST, `/orders/${cartId}/items`, { |
There was a problem hiding this comment.
là on transforme en post pour coller à une maj sylius ?
There was a problem hiding this comment.
On transforme parce que j'avais mis un truc au hasard au début du projet 👀
DuvCharles
force-pushed
the
feat/add-to-cart
branch
from
08b221a
to
da35cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.