fix: clear entity persister on restoring class metadata

[wickedOne]

restoring the class metadata in the metadata factory does not restore the one doctrine has cached in the class property of it's persisters....

downstream this might lead to unexpected behaviour: when the id generator has been replaced with this library's IdGenerator, the basic entity persister does not recognise it as an id generator and treats the identity field as one which can be used for inserts in the BasicEntityPersister::getInsertColumnList method

this can lead to Invalid parameter number: number of bound variables does not match number of tokens errors on subsequent inserts of the entity manager. this change will fix that

[theofidry]

Thanks for the PR @wickedOne, sorry for the late review. Would there be a way to capture this behaviour in the tests?

[wickedOne]

no probs: better late than never :-)

as the persister's class property is not publicly available, it would require some hacky trickery.
if that's ok with you, i can probably come up with something

[theofidry]

does it require to touch the persister class though (the test)? From your PR description, I thought this was somewhat reproducible by loading some fixtures and then doing inserts

[wickedOne]

ah ofc yes, the other way around :-)
yes, that should be possible, i'll giv that a go next week

[wickedOne]

added test which makes sure the entity manager doesn't crash after flushing the entity persister.
so basically remove my modification to the entity persister to see that test fail

the modification to the makefile is somewhat unrelated, but was necessary for me to run it locally (bin directory wasn't created in the vendor bin for doctrine)

[theofidry]

Two tiny things to fix LGTM otherwise, thanks a lot for that

[theofidry]

should be reverted

[wickedOne]

done

[theofidry]

I checked the failures and they look unrelated, thank you @wickedOne