Merge pull request #97 from theonion/fix-non-read-list-art-pos

fix article_position default val
theonion · Nov 16, 2018 · 9d1f011 · 9d1f011
2 parents d96b800 + ed72e78
commit 9d1f011
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/helpers/TargetingPairs.js b/src/helpers/TargetingPairs.js
@@ -50,9 +50,13 @@ var TargetingPairs = {
           return readingListPostIds.indexOf(currentPostId) + 2;
         }
       }
+
+      // Starter post
+      return 1;
     }
 
-    return 1;
+    // Not in reading list
+    return 'none';
   },
 
   /**

diff --git a/src/helpers/TargetingPairs.spec.jest.js b/src/helpers/TargetingPairs.spec.jest.js
@@ -247,7 +247,7 @@ describe('TargetingPairs', function() {
 
       it('returns the index of the article in reading list', function() {
         var childElement = document.body.getElementsByClassName('ad-container')[0];
-        expect(TargetingPairs.getArticlePosition(childElement, {})).toEqual(1);
+        expect(TargetingPairs.getArticlePosition(childElement, {})).toEqual('none');
       });
     });
   });