Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helper functions for annotations, template cleanup #88

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Dec 2, 2024

  • Adds defined helper functions for the entfga Annotations to make it easier to add to schemas. The struct can still directly be used.
  • Cleans up and simplifies template for checks to get rid of unnecessary code that would never be hit ("e.g. "id" != "id" checks are now a template check, and not a check in the code itself.
  • Adds wrapper functions to make using the generated authz checks easier to use

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@github-actions github-actions bot added the enhancement New feature or request label Dec 2, 2024
matoszz
matoszz previously approved these changes Dec 2, 2024
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade enabled auto-merge (squash) December 3, 2024 00:10
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.2% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade merged commit df9acc5 into main Dec 3, 2024
11 of 12 checks passed
@golanglemonade golanglemonade deleted the feat-helper-functions branch December 3, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants