refactor: Add presentational component to Result
#3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
Result
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Sep 30, 2024
DafyddLlyr
force-pushed
the
dp/result-presentational-component
branch
from
84815fa
to
2ff011f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resultcomponent -Node.tsxResultcomponent, with the previous behaviour being delegated to aPresentationalcomponent (for testing & Storybook).Why?
#3716 has slightly descended into a large messy type fixing PR which I was trying to avoid. I'm splitting it up into smaller, more atomic, PRs in order to better highlight and track the actual important changes.
This pattern of using a
Presentationalcomponent is used elsewhere multiple times. This was recently added to theMapAndLabelcomponent here - #3585