Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test[e2e]: add filter and internal portal into create flow test #3739

Merged
merged 6 commits into from
Oct 1, 2024
Merged

test[e2e]: add filter and internal portal into create flow test #3739

merged 6 commits into from
Oct 1, 2024

Conversation

jamdelion
Copy link
Contributor

@jamdelion jamdelion commented Sep 30, 2024 •
edited
Loading

In this PR

  • Add to 'editor side' test: filter and internal portal
  • Add to 'user side' test: navigate through an internal portal
  • Improve AWS SSO doc
  • Re-add in the checklist component (seems to have fixed itself 😅 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jamdelion jamdelion changed the title test[e2e]: add filter and portals into create flow test test[e2e]: add filter and internal portal into create flow test Oct 1, 2024
@jamdelion jamdelion marked this pull request as ready for review October 1, 2024 11:48
@jamdelion jamdelion requested a review from a team October 1, 2024 11:48
DafyddLlyr
DafyddLlyr approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Thanks as well for updating the AWS CLI docs 🏅

@jamdelion jamdelion merged commit 660654b into main Oct 1, 2024
12 checks passed
@jamdelion jamdelion deleted the jh/even-more-e2e-components branch October 28, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamdelion @DafyddLlyr