Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Improve visibility of list component add button #3756

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Oct 3, 2024

What does this PR do?

Improves visibility of the "add new" button for the list component. Abstracts away from common button types to create a custom content-skeleton-esque button for this component.

Preview:
https://3756.planx.pizza/testing/list-add-button/preview

Before:
image

After:
image

Copy link

github-actions bot commented Oct 3, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review October 3, 2024 10:20
@ianjon3s ianjon3s requested a review from a team October 3, 2024 10:20
@ianjon3s
Copy link
Contributor Author

ianjon3s commented Oct 3, 2024

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 💅

@DafyddLlyr
Copy link
Contributor

@ianjon3s Just merging this to get into the next prod deploy! 🚀

@DafyddLlyr DafyddLlyr merged commit aba9b56 into main Oct 3, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the ian/list-component-add-button branch October 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants