Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(search): All text fields are correctly mapped and displayed in SearchResultCard #3799

Merged
merged 16 commits into from
Oct 18, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 11, 2024

What does this PR do?

  • Adds test coverage for getDisplayDetailsForResult()
  • This ensures that all searchable text field within nodes are correctly rendered (a few fields have been added as part of these tests)

There are associated tidy ups and fixes included here also, navigating commit-by-commit should show this.

@DafyddLlyr DafyddLlyr changed the title dp/search all field tests test(search): All text fields are correctly mapped and displayed in SearchResultCard Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr requested a review from a team October 16, 2024 16:31
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 16, 2024 16:31
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really thorough, tedious tests here but easy PR to follow - thanks for working through all these possible cases !!

@@ -50,7 +50,7 @@ const components: {
"external-portal": ExternalPortal,
"file-upload": FileUpload,
filter: Filter,
"find-property-merged": FindProperty,
"find-property": FindProperty,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd remnant, thanks for cleaning up!

@DafyddLlyr DafyddLlyr merged commit cb140bb into main Oct 18, 2024
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/search-all-field-tests branch October 18, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants