-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(search): All text fields are correctly mapped and displayed in SearchResultCard
#3799
Conversation
SearchResultCard
Removed vultr server and associated DNS entries |
e365df9
to
917eda6
Compare
917eda6
to
67b3d79
Compare
37a2283
to
3a89f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thorough, tedious tests here but easy PR to follow - thanks for working through all these possible cases !!
@@ -50,7 +50,7 @@ const components: { | |||
"external-portal": ExternalPortal, | |||
"file-upload": FileUpload, | |||
filter: Filter, | |||
"find-property-merged": FindProperty, | |||
"find-property": FindProperty, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd remnant, thanks for cleaning up!
What does this PR do?
getDisplayDetailsForResult()
There are associated tidy ups and fixes included here also, navigating commit-by-commit should show this.