Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not allow users to resume submitted or deleted sessions #3828

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 21, 2024

What's the problem?

What's the solution?

  • Add a check for submitted and deleted sessions, which matches the public user permission set

What I think is causing this

Screen.Recording.2024-10-21.at.11.04.22.mov

This is now resolved on the Pizza, please see https://3828.planx.pizza/buckinghamshire/report-a-potential-dangerous-structure

Why I'm not totally convinced this is what users are doing

  • The above seems like quite edge-case behaviour, but is happen fairly frequently, and usually a few minutes after submission
  • Submissions are happening as expected however - Slack notifications, email_applications audit log, and Hasura events all seem to confirm this

@DafyddLlyr DafyddLlyr marked this pull request as draft October 21, 2024 09:53
@DafyddLlyr DafyddLlyr changed the title fix: Do not validate submitted or deleted sessions fix: Do not allow users to resume submitted or deleted sessions Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team October 21, 2024 11:04
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 21, 2024 11:04
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for looking into this one - agree it's very strange, and this fix is definitely in the right direction - curious to see if we'll still see it popup !

@DafyddLlyr DafyddLlyr merged commit f5cea21 into main Oct 21, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/cannot-find-session-error branch October 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants