refactor: split out ui file #3865
Conversation
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
I think this should move to /src/ui/editor/ to be located alongside other Editor modal components.
There was a problem hiding this comment.
Thanks, that makes sense! I think I've got a few holes in my understanding of the context around these groupings so that's helpful to have that framing :)
There was a problem hiding this comment.
As above, this should go in /src/ui/editor.
The intention here would be for src/@planx/components to be the graph components. There's a tricky language thing here where these are the lego building blocks of the graph, but the word "component" in the lego block sense clashes with "component" in the web framework sense.
There was a problem hiding this comment.
I wonder if it would make sense to rename one of the folders to graphComponents in that case? 🤔
There was a problem hiding this comment.
Just discussed in dev call - let's stick with /components for now 👍
There was a problem hiding this comment.
Maybe /shared/types.tsx would be more appropriate here?
Sorry for the long diff - most of these are file import changes.
Summary of main changes:
The
ui.tsxfile seemed very random - filled with shared components such asMoreInformation, miscellaneous shared types (e.g.PublicProps) and the long icons mapping constant.shared/icons,shared/types.tsxand moved the components into their own files, which are under/src/ui/editor.types.tsxfromChecklist.tsx