Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grant additional permissions to demoUser role #3880

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 30, 2024

A few issues when testing the demoUser role end-to-end -

  • All users must be able to access their own record in the team_members table in order to log in
  • All users must have read access to the team_settings table

Copy link

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (2)

  • public.team_members permissions:

    insert select update delete
    demoUser
    4 added column permissions
    insert select update
    demoUser ➕ id
    ➕ role
    ➕ team_id
    ➕ user_id
  • public.team_settings permissions:

    insert select update delete
    demoUser
    13 added column permissions
    insert select update
    demoUser ➕ boundary_bbox
    ➕ boundary_url
    ➕ email_reply_to_id
    ➕ external_planning_site_name
    ➕ external_planning_site_url
    ➕ help_email
    ➕ help_opening_hours
    ➕ help_phone
    ➕ homepage
    ➕ id
    ➕ reference_code
    ➕ submission_email
    ➕ team_id

@DafyddLlyr DafyddLlyr requested a review from a team October 30, 2024 16:20
@RODO94
Copy link
Contributor

RODO94 commented Oct 30, 2024

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks aligned with what we spoke about in our call, all fine for me

Copy link

github-actions bot commented Oct 30, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit cabf052 into main Oct 30, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/demo-user-additional-permissions branch October 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants