refactor: expand canUserEdit function to include all user roles #3881
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Oct 30, 2024
RODO94
force-pushed
the
rory/demo-team-filter
branch
from
87a0fdc
to
ce11152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work of the demo workspaces: https://trello.com/c/EfaEQRzK/2441-create-a-demo-workspace
I have expanded the use of the
canUserEditstore function to returntrueas long as therole !== "teamViewer"as the database will populate theuser.teamsarray with all teams the user is a team member of. The only role that can be assigned where you wouldn't be able to edit is theteamViewerrole thus, I went with this for the condition.In other circumstances, a user may be a
teamEditorordemoUserand in both cases this will be assigned only on the teams they can edit