-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feedback component submits to feedback table + tidy ups #3900
Conversation
Removed vultr server and associated DNS entries |
25d8a09
to
47d51bc
Compare
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
e5f317c
to
a8380f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff - working as expected 👍
Code is clear and well structured, easy to review and follow along.
One thing for a follow up PR is to make sure that the component works on "back" - have a look at how the previouslySubmittedData
prop is used in other components.
A few comments below - let me know if you want to talk anything through.
editor.planx.uk/src/@planx/components/Feedback/Editor/Editor.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Feedback/Editor/Editor.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/pages/FlowEditor/components/Flow/FeedbackLog/components/CollapsibleRow.tsx
Show resolved
Hide resolved
@@ -0,0 +1,2 @@ | |||
alter table "public"."feedback" add column "feedback_score" text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see previous comment - maybe an integer column with a CHECK
constraint (e.g. 1-5) is a good option here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I'm not sure of - can I delete some of these migrations to make the PR cleaner? Or is my back and forth on this immortalised forever more? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Can manually combine migrations into a single up.sql
(note you'll want to destroy Vultr before pushing commit so it rebuilds from scratch to test) or there's a Hasura CLI squash command (I find this command finicky and usually go the manual route tbh!)
editor.planx.uk/src/@planx/components/Feedback/Public/Public.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Feedback/Public/Public.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Feedback/Public/Public.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/Feedback/Editor/Editor.tsx
Dismissed
Show dismissed
Hide dismissed
editor.planx.uk/src/@planx/components/Feedback/Editor/Editor.tsx
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes & previous feedback all look good here - happy to approve to not block progressing !
Dismissing "requested changes" while Daf is out sick!
In this PR:
Improvements from comments on previous PR:
more information
link not appearing as expect on public componentRichTextInput
forTextInput
component in public viewplaceholders
file given will be used in templates, and made the object typeable.Also:
_feedback
to breadcrumbs on submitHow to test 🧪
🎟️ Trello ticket: https://trello.com/c/jEOLoubW/3034-can-we-introduce-in-house-end-of-service-feedback
Todo:
_feedback
key in metabase (add toallow_list
s)previouslySubmittedProps