Add convenience target for running in the current working directory #29
+74
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-theorem
approved these changes
Apr 16, 2024
mark-thm
commented
Apr 16, 2024
Comment on lines
-1
to
-4
| exports_files( | ||
| ["multitool.lock.json"], | ||
| ) | ||
|
|
There was a problem hiding this comment.
turns out this wasn't necessary
Closed
alexeagle
reviewed
Apr 16, 2024
| execdir="$PWD" | ||
|
|
||
| pushd "$BUILD_WORKING_DIRECTORY" > /dev/null | ||
| "$execdir/$tool" "$@" |
There was a problem hiding this comment.
I think this is wrong, it leaves a bash process as the parent of the tool process, interfering with signals and leaving a messy pstree. I think you want exec here to replace the current process.
(Also I don't see the point of popd since the shell exits at that point and whatever directory it was running in is lost)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for users of multitool to want to run tools in the current working directory. In #26, @alexeagle documented a technique we've used for a while with creating a script and symlinking to it. Our internal copy of this script is a bit more complicated to help avoid expensive calls to Bazel that simple
bazel runcalls don't really need. More refinements have been proposed in #27. All of these things are fundamentally workarounds for bazelbuild/bazel#3325.To help simplify things, this PR adds a convenience wrapper that captures the execpath, switches to $BUILD_WORKING_DIRECTORY, and then runs the desired tool. The resulting shell script gets to use a very simple
bazel run, should be compatible across any slew of Bazel options, and cache as well as any typical run target.