Skip to content

Commit

Permalink
Add comment around perf improvement
Browse files Browse the repository at this point in the history
  • Loading branch information
mark-thm committed Jul 29, 2024
1 parent 6406f97 commit e3307e7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions mypy/private/mypy.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ def _mypy_impl(ctx):
if file.root.path:
generated_dirs[file.root.path] = 1

# TODO: can we use `ctx.bin_dir.path` here to cover generated files
# and as a way to skip iterating over depset contents to find generated
# file roots?
unique_generated_dirs = generated_dirs.keys()

# types need to appear first in the mypy path since the module directories
Expand Down

0 comments on commit e3307e7

Please sign in to comment.