Fix default mypy.ini and update readme #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #15. We set
--follow-imports=silent
when we call the CLI, which generally prevents type-checking 3rd party dependencies. When 3rd party dependencies contain typings in .pyi files, we also need to setfollow_imports_for_stubs = True
.Summary
Set reasonable defaults in the (mandatory if not otherwise provided)
default_mypy.ini
file. Update the README to clarify that the contents of mypy.ini should contain some instructions around following imports.