Add support for generated files with custom imports #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the source files of a py_library are generated, and the library has custom `imports`, we need to add both the imports path and the generated dir's relative import path to the MYPYPATH
mark-thm
reviewed
Nov 15, 2024
| generated_custom_imports = [] | ||
| for generated_dir in unique_generated_dirs: | ||
| for custom_import in custom_imports: | ||
| generated_custom_imports.append("{}/{}".format(generated_dir, custom_import)) |
There was a problem hiding this comment.
I guess some of these may just not exist?
There was a problem hiding this comment.
Yea. I figured that shouldn't hurt
There was a problem hiding this comment.
happy to roll with it -- only a mild concern about potential size of the env var, but that's a problem for another time
mark-thm
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source files of a py_library are generated, and the library has
custom
imports, we need to add both the imports path and the generateddir's relative import path to the MYPYPATH