Transition uv to the correct platform #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenmj
force-pushed
the
mmj/uv-transition
branch
2 times, most recently
from
d4269dd
to
8e57fa1
Compare
mortenmj
force-pushed
the
mmj/uv-transition
branch
from
8e57fa1
to
b3386bd
Compare
mark-thm
approved these changes
Sep 11, 2024
mark-thm
reviewed
Sep 11, 2024
mark-thm
reviewed
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, uv is selected for the exec platform. If it were used as part of a build action, this would be correct, but as it is invoked by an emitted shell script it is not. This causes it to fail when running builds on one platform, but targeting another. This is the case, for example, when running builds in a remote execution cluster with Linux workers, but compiling for a Mac. This patch transitions uv to the proper platform, allowing it to work in this situation.