Use uv pip sync and allow-existing instead of uv pip install #166
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewianda
force-pushed
the
feat-use-uv-sync
branch
from
933759c
to
5ab302b
Compare
|
@mark-thm could please take a look |
mark-thm
approved these changes
Nov 14, 2024
|
@ewianda: I may need to revert this -- there's a slight behavior change which is breaking one of our use cases -- we use create_venv to make some tooling virtual environments without first expanding inputs to lockfiles, and |
Merged
thm-automation bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
In #166, create_venv was switched to perform a `uv pip sync`, but this has slightly different semantics than `uv pip install`. The latter will expand the input requirements as needed, while the former treats the input as a complete lockfile. To achieve both behaviors, revert `create_venv` to its old functionality and add a `sync_venv` macro that runs `uv pip sync`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
uv venvwipes out the virtual env target, resulting in longer installations when using private pypi indexes that don't support caching. Adding theallow-existingmaintains the virtualenv if it exists, and usinguv pip syncensures the virtualenv doesn't retain unused dependencies.