Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress reviewbot on individual job items #34

Merged
merged 1 commit into from
May 21, 2024
Merged

Suppress reviewbot on individual job items #34

merged 1 commit into from
May 21, 2024

Conversation

mark-thm
Copy link
Contributor

We're trying to get reviewbot not to fail on contributions from a fork -- the prior attempt in #25 didn't seem to do the trick.

@mark-thm mark-thm requested review from reviewbot-theorem and a team as code owners May 21, 2024 14:45
@thm-automation thm-automation bot enabled auto-merge (squash) May 21, 2024 14:47
@thm-automation thm-automation bot merged commit b6fd42e into main May 21, 2024
6 checks passed
@thm-automation thm-automation bot deleted the me/ci branch May 21, 2024 15:17
thm-automation bot pushed a commit that referenced this pull request May 21, 2024
## Issue
In #25 and #34 we've been trying to make it so that reviewbot doesn't fail when submissions come from 3rd party repos. #34 moved the suppression from the job to the step, but we still see a failure in #35 -- reading the failure more closely it seems to be because the secret is absent and the action validator still runs.

## Summary
Add an alternate value to the reviewbot secret to help pass validation and move the suppression back to the job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants