Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily stop doing t.Parallel for tests with panic #350

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

maditya
Copy link
Contributor

@maditya maditya commented Jan 3, 2024

Until further investigation is done, this will reduce flakiness in PR builds

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc4a1f4) 77.79% compared to head (4c6d64a) 78.50%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   77.79%   78.50%   +0.70%     
==========================================
  Files          26       26              
  Lines        1833     1833              
==========================================
+ Hits         1426     1439      +13     
+ Misses        382      369      -13     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maditya maditya changed the title Update log_test.go temporarily stop doing t.Parallel for tests with panic Jan 3, 2024
@maditya maditya marked this pull request as ready for review January 3, 2024 14:27
@py4chen py4chen merged commit 1b640f5 into main Jan 3, 2024
8 checks passed
@py4chen py4chen deleted the maditya-patch-1 branch January 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants