Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): add escalation tile to H2/3 dashboard #314

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Conversation

AnthonyFuller
Copy link
Contributor

@AnthonyFuller AnthonyFuller commented Aug 5, 2023

This PR adds an escalations tile to the H2/3 dashboard, replacing the 4 featured Peacock escalations.

This tile just opens the enhanced "ContractAttack" hit category.
image

Also adds an elusive targets tile to the H2 dashboard, which functions the same as Career -> Elusive Targets (just fills it out)
image

This PR also adds some category names to certain logs, as I kept getting annoyed with the "unknown".

Currently marked as a draft until the tile has been fixed

@AnthonyFuller AnthonyFuller changed the title feat feat(menu): add escalation tile to H2/3 dashboard Aug 5, 2023
@AnthonyFuller AnthonyFuller marked this pull request as draft August 5, 2023 07:35
@AnthonyFuller
Copy link
Contributor Author

AnthonyFuller commented Aug 6, 2023

I have just pushed a working tile for the H3 escalation tile on the dash.

It is a bit hacky as we hijack the arcade page for it to work. The old method does not work due to some menu limitation we've hit. This method is compatible with (a future version) of Heritage UI.

@AnthonyFuller
Copy link
Contributor Author

Just pushed the page and tile for H2.

It is an unbelieveably hacky method.

@AnthonyFuller AnthonyFuller marked this pull request as ready for review August 6, 2023 09:24
@AnthonyFuller AnthonyFuller requested a review from RDIL August 6, 2023 09:24
@grappigegovert
Copy link
Member

Just pushed the page and tile for H2.

It is an unbelieveably hacky method.

... Wow

Nice job getting it to work tho!

@AnthonyFuller
Copy link
Contributor Author

AnthonyFuller commented Aug 6, 2023

Yep, thanks. Had to push the whole gamemodesniper_content.json template instead of the 6-ish line gamemodesniper_page.json which wasn't getting retrieved from the servers (likely due to it being used the menuresources brick).

I was already hijacking the arcade page, which was fine as it's a short template.

This all adds onto $arraygroupby crashing with the order property in H2, so I have to push Peacock escalations first and then the rest.

EDIT:
For future reference, I was having issues with getting $groupby and $orderby working, it just produced a blank page.

@RDIL RDIL added the backlog This needs to be reviewed. label Aug 16, 2023
@AnthonyFuller
Copy link
Contributor Author

This has been ready to merge since the last commit has been made.

@AnthonyFuller
Copy link
Contributor Author

@RDIL this is ready to be merged, could it get your review please?

@AnthonyFuller AnthonyFuller merged commit 8189757 into v7 Sep 5, 2023
6 checks passed
@AnthonyFuller AnthonyFuller deleted the escalation-tile branch September 5, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants