Fix Windows path handling and simplify path normalization. #751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Even though Linux supports backslashes, I haven't checked all the other adapters to see what they support. And, since backslashes are directory separators on Windows, we could wind up with different file structures if we allowed them. This seems like the lowest common denominator.
Also, I've merged
normalizePath()
andnormalizeRelativePath()
since I don't see a safe subset fornormalizeRelativePath()
to do, or how they are really different.