Enable TIFF image format handling, fixes #344 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add imagick to the extensions list here to ensure it's available glide/.github/workflows/test.yaml Line 39 in 3aa4539 |
|
I've added that. |
ADmad
reviewed
Feb 21, 2022
|
Thanks |
|
Thank you! New release done. |
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #344, here's a PR to enable TIFF image format support. I saw that there were some vestiges of TIFF format support already (for example the
tifproperty in the test case), so I've made use of that. The test suite runs only with thegddriver, so operations that requireimagick(which includes the TIFF format) can't be tested, so I wrote a new test method that reconfigures the test to run with imagick, and skips the test if it's not installed.I don't understand how the mock works in
testGetFormat– I tried copying it but couldn't make it work, so I've not created a similar test for that.