Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing throws annotation #408

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add missing throws annotation #408

merged 1 commit into from
Dec 17, 2024

Conversation

guillaume-sainthillier
Copy link
Contributor

Hello,

phpstan v2 complains about catching FileNotFoundException when calling the Server::getImageResponse.
But makeImage can actually throw those errors, so i've added them into the public methods

@guillaume-sainthillier guillaume-sainthillier mentioned this pull request Dec 16, 2024
Merged
@ADmad ADmad merged commit dab24ea into thephpleague:master Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deluxetom deluxetom deluxetom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaume-sainthillier @deluxetom @ADmad