Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return StreamInterface instead of string in mocked ResponseInterface::getBody() functions #27

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

fabacino
Copy link
Contributor

@fabacino fabacino commented Nov 7, 2024

As defined in https://github.com/php-fig/http-message/blob/master/src/MessageInterface.php, ResponseInterface requires getBody() to return a StreamInterface.

@shadowhand shadowhand merged commit a441b2e into thephpleague:main Nov 7, 2024
1 of 6 checks passed
@fabacino fabacino deleted the return-stream-in-getbody branch November 7, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants