Request implementation doesn't consider that HTTP headers are case-insensitive #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on mayuscula." This reverts commit a2a5a04.
|
The request class already normalises the headers |
|
Nope, it doesn't. You only are normalizing the headers when the getallheaders function doesn't exist. The getallheaders function doesn't normalize the headers. |
alexbilbie
added a commit
that referenced
this pull request
Dec 5, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC2616, HTTP headers are case-insensitive.
For example, when using Google OAuth2 Playground to test my server, it fails because Google OAuth2 Playground send the "Authorization" header as "authorization".