Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring leeway for the validation of jwt token dates #1304

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

annervisser
Copy link
Contributor

Fixes #1021

@annervisser
Copy link
Contributor Author

I've just rebased this onto master to resolve conflicts

@Sephster Anything we can do to help get this merged?

We're currently having to run our own fork of this project with this fix. We've run into production errors due to time drift issues (running multiple fpm workers on separate machines) multiple times.

Copy link
Member

@Sephster Sephster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this and apologies I haven't picked it up til now. Looks good to me so happy to merge. Thanks very much for taking the time to submit this

@Sephster Sephster merged commit 4677b2f into thephpleague:master Nov 17, 2022
@annervisser
Copy link
Contributor Author

Thanks very much for this and apologies I haven't picked it up til now. Looks good to me so happy to merge. Thanks very much for taking the time to submit this

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Leeway in JWT Validation
2 participants