Always validate the client and determine if it handles the grant type #1420
+82
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174
Fixes #1369
Related to #1073
Closes #1036
This PR can be considered as a security enhancement and does 2 main changes:
AbstractGrant::validateClient()
only if the client is confidential. This PR fixes this inconsistent behavior and makes the server always callAbstractGrant::validateClient()
.AbstractGrant::getClientEntityOrFail()
twice instead of just using theAbstractGrant::validateClient()
return value, this PR fixes that.ClientRepository::validateClient()
: validate the client secret only if the client is confidential. It's already implemented this way on most community integrations:ClientEntityInterface::hasGrantType()
function:ClientTrait
that returnstrue
by default to avoid BC breaking changes.