Fixed Template->render() exception handling #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the template was found but the layout was not, a notice was being emitted: "failed to delete buffer. No buffer to delete." Additionally, within the branch to catch a LogicException, rather than the existing LogicException instance being re-thrown, a new one was being instantiated with the message of the original, losing trace information in the process.
|
Love it, thanks for working this out Matt! |
reinink
added a commit
that referenced
this pull request
Jul 9, 2015
Fixed Template->render() exception handling
|
@reinink Ha, you're quick. I'd just tweeted this at you. :p Thanks! |
|
Haha, not always! Tagged. |
|
@reinink Ha! Was just about to ask if you'd tag a release. It's like you're in my head or something. ;) Thank you sir! :D |
1 task
okaprinarjaya
pushed a commit
to okaprinarjaya/plates
that referenced
this pull request
Jan 7, 2024
…ceptions Jonathan Reinink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template->render()callsob_get_clean()to get the result of rendering the template. According to the PHP manual page for this function, this is what it does, emphasis mine:After this function is called, another block is executed to render the layout. Within this block, it's possible for a
LogicExceptionto be thrown if, for example, the layout template cannot be found. If this happens, there is acatchblock to handle it.There are two problems with this
catchblock:ob_get_clean()deleted the output buffer, the call toob_end_clean()in thecatchblock has no buffer to delete and thus causes a notice to be emitted: "failed to delete buffer. No buffer to delete."LogicExceptioninstance being re-thrown, a new one is being instantiated with the message of the original, causing the trace information associated with the original to be lost. This makes debugging difficult.This PR applies these corrections:
ob_end_clean()call in aob_get_length()check so that it is only called if needed, avoiding the previously emitted notice.LogicExceptioninstance so that the original trace information is preserved.