Update codestyle, php version, tests, add interface #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-style (PSR) check with phpcs add interface for the client update phpunit version and tests use github actions
andrew-demb
reviewed
Oct 31, 2021
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
|
@marcqualie would you be willing to take a look? |
|
This PR looks good to me 👍 |
colinodell
approved these changes
Dec 23, 2021
|
@colinodell I think this can be merged now? |
|
I'll get it merged sometime this week (possibly this weekend). I'd also like to review the other outstanding PRs and see if we can include them too :) |
nyamsprod
reviewed
Jan 11, 2022
|
Version 2.0.0 has been released! Thanks so much for your help with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library hasn't been updated in a while. I'm not sure if that's intentional, but I've taken an attempt to modernize this library a bit. I hope an update for this library can be considered. If this is not the right approach of some changes should be left out / split in other PRs, let me know.
I've added an interface, which would be nice to have for dependency injection and mocking in tests. Updated PHPUnit and the tests. Used the last maintained PHP version as minimum and used types where possible. Applied the PSR codestyle. Added GitHub actions configuration.