Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<iframe> improvements and alternative solutions exploration #19

Open
1 of 5 tasks
thescientist13 opened this issue Aug 1, 2021 · 5 comments
Open
1 of 5 tasks

<iframe> improvements and alternative solutions exploration #19

thescientist13 opened this issue Aug 1, 2021 · 5 comments
Assignees
@thescientist13
Labels
enhancement New feature or request needs upstream question Further information is requested
Milestone
MVP

Comments

@thescientist13
Copy link
Owner

thescientist13 commented Aug 1, 2021 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Using an <iframe> was the quickest implementation I could think of here but I'm not sure if it is the only option here? It does seem bit cumbersome to have to load every page like this, but maybe a SPA or MPA architecture might work?

Details

TBD 🤔
@thescientist13 thescientist13 added the question Further information is requested label Aug 1, 2021
@thescientist13 thescientist13 added this to the MVP milestone Aug 1, 2021
This was referenced Aug 1, 2021
Open
Closed
@thescientist13 thescientist13 self-assigned this Aug 10, 2021
@thescientist13 thescientist13 mentioned this issue Aug 12, 2021
Closed
5 tasks
@thescientist13 thescientist13 changed the title <iframe> alternative solutions and exploration <iframe> improvements and alternative solutions exploration Aug 16, 2021
@thescientist13 thescientist13 added the enhancement New feature or request label Aug 16, 2021
@thescientist13 thescientist13 pinned this issue Aug 16, 2021
@thescientist13
Copy link
Owner Author

A couple ideas to help offset the cost that having multiple <iframe>s on the page at once causes (e.g. a flood of HTTP requests)

  • inline styles and JS, either manually or using data-gwd-opt (the latter of which would only happen at build time)
  • get caching improvements from upstream, which should at least help for development

@thescientist13 thescientist13 mentioned this issue Aug 16, 2021
Closed
5 tasks
@thescientist13
Copy link
Owner Author

Or do we just do some sort of static pre-rerendering using Puppeteer and export only HTML and some sort of HTML include? 🤔

@thescientist13
Copy link
Owner Author

Some other thoughts, though I don't know much about them but worth looking into

@thescientist13
Copy link
Owner Author

On the topic of portals, that may be relevant
https://dev.to/westbrook/your-portal-content-through-a-litelement-5h8b

@thescientist13
Copy link
Owner Author

Could use the page transition API somehow?

@thescientist13 thescientist13 mentioned this issue Jul 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
enhancement New feature or request needs upstream question Further information is requested
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@thescientist13