Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/upgrade greenwood v0.30.0 #71

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Mar 10, 2024

Related Issue

N / A

Summary of Changes

  1. Upgrade Greenwood v0.30.0
  2. Refactor from templates to layouts

TODO

  1. theme.css being handled as a Constructable Stylesheet? - docs/refine theme pack guide for local dev ProjectEvergreen/greenwood#1228
    Screenshot 2024-05-06 at 1 45 15 PM

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for awesome-bhaskara-b7d76c ready!

Name Link
🔨 Latest commit 375a4cb
🔍 Latest deploy log https://app.netlify.com/sites/awesome-bhaskara-b7d76c/deploys/66eb7c124d588900085a3790
😎 Deploy Preview https://deploy-preview-71--awesome-bhaskara-b7d76c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13
Copy link
Owner Author

thescientist13 commented Sep 19, 2024

A new ESLint error started popping up in the logs
https://github.com/thescientist13/greenwood-starter-presentation/actions/runs/9628754689/job/26557334532?pr=71

Run yarn lint
yarn run v1.22.22
$ npm run lint:js && npm run lint:css

> greenwood-starter-presentation@0.8.1 lint:js
> eslint "*.js" "./src/**/*.js"

There was a problem loading formatter: /home/runner/work/greenwood-starter-presentation/greenwood-starter-presentation/node_modules/eslint/lib/cli-engine/formatters/stylish
Error: require() of ES Module /home/runner/work/greenwood-starter-presentation/greenwood-starter-presentation/node_modules/strip-ansi/index.js from /home/runner/work/greenwood-starter-presentation/greenwood-starter-presentation/node_modules/eslint/lib/cli-engine/formatters/stylish.js not supported.
Instead change the require of index.js in /home/runner/work/greenwood-starter-presentation/greenwood-starter-presentation/node_modules/eslint/lib/cli-engine/formatters/stylish.js to a dynamic import() which is available in all CommonJS modules.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

ESLint issue seems to have known inconsistent behavior with Yarn 1.x and now seems like the perfect time to just move this repo over to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant