Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -r option in security-audit script #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,21 @@ shell: build

# Security Audit

SecurityAuditRole=AssumableSecurityAuditRole

security-audit-accounts:
ifndef Accounts
$(error Accounts is undefined)
endif
echo $(Accounts)
docker-compose build aws-baseline
docker-compose run aws-baseline ./scripts/security-audit -p $(Accounts)
docker-compose run aws-baseline ./scripts/security-audit -p -r $(SecurityAuditRole) $(Accounts)

clean-reports:
rm -fr reports

security-audit-all: build clean-reports
docker-compose run aws-baseline ./scripts/security-audit -p
docker-compose run aws-baseline ./scripts/security-audit -p -r $(SecurityAuditRole)

security-audit-docker-with-rebuild: rebuild-baseline security-audit-all

Expand Down
2 changes: 1 addition & 1 deletion scripts/security-audit
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ SECONDS=0

while getopts "r:pmd:" opt; do
case "$opt" in
r) AUDIT_ROLE='$OPTARG' ;;
r) AUDIT_ROLE="$OPTARG" ;;
p) PARALLEL='TRUE' ;;
d) ASSUME_DURATION="-d $OPTARG" ;;
m) ASSUME_MFA="-m" ;;
Expand Down