Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in 1.3.0 #44

Closed
wferem1 opened this issue Dec 13, 2023 · 3 comments
Closed

Breaking change in 1.3.0 #44

wferem1 opened this issue Dec 13, 2023 · 3 comments
Assignees

Comments

@wferem1
Copy link

wferem1 commented Dec 13, 2023

Describe the Issue

The constructor of EasyImageView now has differently named parameters, which is considered a breaking change
in version 1.2.1:

  const EasyImageView({
    Key? key,
    required this.imageProvider,
    this.minScale = 1.0,
    this.maxScale = 5.0,
    this.doubleTapZoomable = false,
    this.onScaleChanged,
  }) : super(key: key);

in version 1.3.0

 const EasyImageView({
    Key? key,
    required this.imageWidget,
    this.minScale = 1.0,
    this.maxScale = 5.0,
    this.doubleTapZoomable = false,
    this.onScaleChanged,
  }) : super(key: key);

Todo

Expected behavior

Rename the parameter back to the old version, or retract the current version and release it as 2.0.0

Steps to Reproduce

n/a

Other Information

retract pub package

@jfahrenkrug
Copy link
Collaborator

@wferem1 Thank you for reporting this and sorry for the inconvenience. I've retracted 1.3.0 and am working on a fix. I'll post an update here.

@jfahrenkrug jfahrenkrug self-assigned this Dec 13, 2023
@jfahrenkrug
Copy link
Collaborator

@wferem1 PR: #45

@jfahrenkrug
Copy link
Collaborator

@wferem1 1.3.1 has been released (https://pub.dev/packages/easy_image_viewer), thanks again. I'm closing the ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants