Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert breaking constructor change introduced in 1.3.0 #45

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jfahrenkrug
Copy link
Collaborator

Revert breaking constructor change introduced in 1.3.0. This changes the default EasyImageView constructor back to accepting an ImageProvider instead of a Widget. Constructing an EasyImageView with a widget can be done by using a new named constructor: EasyImageView.imageWidget.

Thank you to @wferem1 for reporting this.

Description

Todo

Checklist

Please ensure your pull request fulfills the following requirements:

  • The commit messages follow our guidelines (CONTRIBUTING.md)
  • Tests for any changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Type

What kind of change does this pull request introduce?

[ ] Bug fix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] Other (please describe below)

Breaking Changes

Does this pull request introduce any breaking changes?

[ ] Yes
[X] No

Other Information

See description above.

Revert breaking constructor change introduced in 1.3.0. This changes the default `EasyImageView` constructor back to accepting an `ImageProvider` instead of a `Widget`. Constructing an `EasyImageView` with a widget can be done by using a new named constructor: `EasyImageView.imageWidget`.

Thank you to @wferem1 for reporting this.
@jimjenkins5
Copy link
Contributor

LGTM. Thanks for the quick turnaround @jfahrenkrug

@jimjenkins5 jimjenkins5 merged commit 7ace790 into main Dec 13, 2023
1 check passed
@jimjenkins5 jimjenkins5 deleted the fix_breaking_constructor_change branch December 13, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants