feat: Add option to allow swipe-down to dismiss #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ticket asked for swipe-to-dismiss (#14) It's easy to implement and now supported with the `swipeDismissible` argument. This allows the user to drag the dialog down to dismiss it. Initially there was a problem when the user zoomed in and tried to pan around on the zoomed-in image: The `Dismissible` widget's GestureDetector would take over and enter the dismissal animation. Watching the image's scale and then changing the Dismissible's `dismissDirection` from `down` to `none` solves the issue. However, additionally a `GlobalObjectKey` was needed for the PageView because Dismissible changes the location of the widget in the widget tree when its `dismissDirection` is changed to `none`. See https://github.com/flutter/flutter/blob/2aa348b9407e96ffe4eca8e8f213c7984afad3f7/packages/flutter/lib/src/widgets/dismissible.dart#L692 See flutter/flutter#108961 See https://www.youtube.com/watch?v=kn0EOS-ZiIc
justinlettau
approved these changes
Aug 4, 2022
|
Hey, @jfahrenkrug! Thanks for this useful plugin! 🙂 Are you planning to publish v1.0.5 on pub.dev soon? I want to implement swipe to dismiss on my app. |
|
@felipebueno Hey Felipe, thank you :) We've just released version 1.1.0: https://pub.dev/packages/easy_image_viewer/changelog#110 Enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A ticket asked for swipe-to-dismiss (#14)
It's easy to implement and now supported with the
swipeDismissibleargument.This allows the user to drag the dialog down to dismiss it.
Initially there was a problem when the user zoomed in and tried to pan around on the
zoomed-in image: The
Dismissiblewidget's GestureDetector would take over andenter the dismissal animation. Watching the image's scale and then changing the Dismissible's
dismissDirectionfromdowntononesolves the issue. However, additionally aGlobalObjectKeywas needed for the PageView because Dismissible changes the location ofthe widget in the widget tree when its
dismissDirectionis changed tonone.See https://github.com/flutter/flutter/blob/2aa348b9407e96ffe4eca8e8f213c7984afad3f7/packages/flutter/lib/src/widgets/dismissible.dart#L692
See flutter/flutter#108961
See https://www.youtube.com/watch?v=kn0EOS-ZiIc
Type
What kind of change does this pull request introduce?
Breaking Changes
Does this pull request introduce any breaking changes?