Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-tap zoom scale #65

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

iazel
Copy link

@iazel iazel commented Jun 30, 2024

Description

Introduce a new parameter to allow library users to modify how much an image will be zoomed in on double tap.

We have also exposed minScale and maxScale on the main entry-point showImageViewer.

Type

What kind of change does this pull request introduce?

[ ] Bug fix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other (please describe below)

Breaking Changes

Does this pull request introduce any breaking changes?

[ ] Yes
[x] No

Other Information

Tests already cover this use case

@iazel iazel closed this Jun 30, 2024
@iazel
Copy link
Author

iazel commented Jun 30, 2024

Looks like I was too hasty with the PR, there is a bug, I'll open it again once I fix it

@iazel iazel reopened this Oct 13, 2024
@iazel
Copy link
Author

iazel commented Oct 13, 2024

Fixed, now double tap to zoom works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant