Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base config updates needed for 6.7.0 onwards #87

Merged

Conversation

ujfalusi
Copy link

HDMI audio got broken due to missing DRM_FBDEV_EMULATION=y
zstd compressed firmware files are not loading (affecting at least Arch/Artix)

Growing number of distro started to package linux-firmware with zstd
compression.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
With the 6.7.0-rc2 update preparation with the sof-kconfig generated config
we lost HDMI audio on all platforms.
It turned out that the reason for it is that DRM_FBDEV_EMULATION is no
longer enabled.
See the following commits:
bb6c4507fe82 ("drm: fix up fbdev Kconfig defaults")
a5ae331edb02b ("drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION")
701d2054fa317 ("fbdev: Make support for userspace interfaces configurable")

and possibly more.

The connection is not clear, but we cannot afford to loose HDMI audio.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
@@ -77,6 +77,9 @@ CONFIG_FB=y
CONFIG_FRAMEBUFFER_CONSOLE=y
# add support for using the EFI framebuffer as console
CONFIG_FB_EFI=y
# FB emulation appears to be needed for HDMI audio (!) support and
# it is not enabled default since 6.7.0-rc1
CONFIG_DRM_FBDEV_EMULATION=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi @kv2019i this looks very odd to me, has this been reported to the DRM/i915 folks? I really see no connection with display audio ....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart, yes, it looks odd, you can try it with thesofproject/linux#4717
I have reached out to the i915 guys, I think it will go down to create an issue in their gitlab place (need to create account and stuff).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, without this change we cannot move to 6.7.0 base for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's merge this and keep the thread alive, we can always revert later.

@plbossart plbossart merged commit 2cdad62 into thesofproject:master Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants