Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-defconfig: add PINCTRL for MTL #89

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

keqiaozhang
Copy link

Need to enable PINCTL for MTL to solve the codec driver probe issue on Rex

Need to enable PINCTL for MTL to solve the codec driver probe issue on Rex

Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
@plbossart plbossart merged commit 135c26e into thesofproject:master Jan 22, 2024
4 checks passed
@mengdonglin
Copy link

mengdonglin commented Jan 23, 2024

@plbossart Could you share more info why only I2S codec RT5682S depends on pinctrl/GPIO support for MTL?

https://github.com/thesofproject/linux/blob/topic/sof-dev/drivers/pinctrl/intel/pinctrl-meteorlake.c defined not only GPIO pins used as I2C (SCL and SDA) to connect RT5682S, but also those SDW and HDA pins. And I think these pin mux are configured by UEFI BIOS or coreboot. HDAudio and SDW codecs works fine without CONFIG_PINCTRL_METEORLAKE. It seems kernel only needs pinctrl/GPIO for I2C.

@plbossart
Copy link
Member

@mengdonglin I think you answered to your own question: the probe failures are entirely related to I2C access. I2S is only used for data and not for probe. If there was a pin-mux issue on the I2S pins, you would see it only when trying to enable a transfer (e.g. clock stuck on low or high, data not enabled, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants