Skip to content

Commit

Permalink
ASoC: SOF: Intel: remove misleading error trace from IRQ thread
Browse files Browse the repository at this point in the history
Downgrade "nothing to do in IRQ thread" message from error to a debug
message in the IPC interrupt handler thread.

The spurious wake-up can happen if a HDA stream interrupt is
raised while the IPC interrupt thread is running. IPC functionality
is not impacted by this condition, so debug is a more appropriate
trace level.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
  • Loading branch information
kv2019i authored and ranj063 committed Jul 15, 2019
1 parent 4a8b4fb commit 04b9bfe
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions sound/soc/sof/intel/cnl.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ static irqreturn_t cnl_ipc_irq_thread(int irq, void *context)
/*
* This interrupt is not shared so no need to return IRQ_NONE.
*/
dev_err_ratelimited(sdev->dev,
"error: nothing to do in IRQ thread\n");
dev_dbg_ratelimited(sdev->dev,
"nothing to do in IPC IRQ thread\n");
}

/* re-enable IPC interrupt */
Expand Down
4 changes: 2 additions & 2 deletions sound/soc/sof/intel/hda-ipc.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context)
/*
* This interrupt is not shared so no need to return IRQ_NONE.
*/
dev_err_ratelimited(sdev->dev,
"error: nothing to do in IRQ thread\n");
dev_dbg_ratelimited(sdev->dev,
"nothing to do in IPC IRQ thread\n");
}

/* re-enable IPC interrupt */
Expand Down

0 comments on commit 04b9bfe

Please sign in to comment.