Skip to content

Commit

Permalink
selftests/mm: protection_keys: save/restore nr_hugepages settings
Browse files Browse the repository at this point in the history
Save and restore nr_hugepages before changing it during the test.  A test
should not change system wide settings.

Link: https://lkml.kernel.org/r/20240125154608.720072-5-usama.anjum@collabora.com
Fixes: 5f23f6d ("x86/pkeys: Add self-tests")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
musamaanjum authored and akpm00 committed Feb 22, 2024
1 parent 7d695b1 commit c23ea61
Showing 1 changed file with 34 additions and 0 deletions.
34 changes: 34 additions & 0 deletions tools/testing/selftests/mm/protection_keys.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ int test_nr;
u64 shadow_pkey_reg;
int dprint_in_signal;
char dprint_in_signal_buffer[DPRINT_IN_SIGNAL_BUF_SIZE];
char buf[256];

void cat_into_file(char *str, char *file)
{
Expand Down Expand Up @@ -1744,13 +1745,46 @@ void pkey_setup_shadow(void)
shadow_pkey_reg = __read_pkey_reg();
}

void restore_settings_atexit(void)
{
cat_into_file(buf, "/proc/sys/vm/nr_hugepages");
}

void save_settings(void)
{
int fd;
int err;

if (geteuid())
return;

fd = open("/proc/sys/vm/nr_hugepages", O_RDONLY);
if (fd < 0) {
fprintf(stderr, "error opening\n");
perror("error: ");
exit(__LINE__);
}

/* -1 to guarantee leaving the trailing \0 */
err = read(fd, buf, sizeof(buf)-1);
if (err < 0) {
fprintf(stderr, "error reading\n");
perror("error: ");
exit(__LINE__);
}

atexit(restore_settings_atexit);
close(fd);
}

int main(void)
{
int nr_iterations = 22;
int pkeys_supported = is_pkeys_supported();

srand((unsigned int)time(NULL));

save_settings();
setup_handlers();

printf("has pkeys: %d\n", pkeys_supported);
Expand Down

0 comments on commit c23ea61

Please sign in to comment.