ASoC: SOF: fix PCM playback through ALSA OSS emulation #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juimonen
reviewed
Jan 10, 2020
lgirdwood
requested changes
Jan 10, 2020
kv2019i
force-pushed
the
topic/oss-emul-bug
branch
from
b3ddca2 to
cbab060
Compare
Any app using ALSA OSS emulation on top of SOF will fail to error from OSS SNDCTL_DSP_SETFMT ioctl. Reported initially as an issue with xournalpp (application using PortAudio with an OSS backend), but applies more generally to other apps using OSS as well. Problem is caused by SOF PCM not supporting repeated calls to hw_params(), without matching calls to pcm_free(). This is however exactly what the ALSA OSS PCM code is doing when it is handling the OSS ioctls. The problem will lead to leaking of DSP resources and eventual failure of DSP PCM_PARAMS IPC. BugLink: thesofproject#1510 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
topic/oss-emul-bug
branch
from
cbab060 to
f1e767f
Compare
|
@juimonen wrote:
Oops. Thanks! It seems default codespell file for checkpatch is quite limited for typos like this. Oh well, there was at least one another bizarre sentence in the commit. Now fixed. |
lgirdwood
approved these changes
Jan 10, 2020
juimonen
approved these changes
Jan 10, 2020
plbossart
approved these changes
Jan 10, 2020
|
Great, thanks! Will give it a roll ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any app using ALSA OSS emulation on top of SOF will fail
to error from OSS SNDCTL_DSP_SETFMT ioctl. Reported initially
as an issue with xournalpp (application using PortAudio with
an OSS backend), but applies more generally to other apps
using OSS as well.
Problem is caused by a problem in SOF PCM code where code does
not support repeatedly calling hw_params(), withoout
matching calls to pcm_free(). This is however exactly what
the ALSA OSS PCM code is doing when it is handling the OSS
ioctls.
The problem will lead to leaking of DSP resource and eventual
failure of DSP PCM_PARAMS IPC.
Fixes: #1510