-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/ actions: replace travis #49
Merged
+51
−25
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--codespell | ||
--codespellfile scripts/spelling.txt | ||
--ignore C99_COMMENT_TOLERANCE | ||
--no-tree | ||
--strict | ||
-g |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
# Basic build test | ||
|
||
name: build | ||
|
||
# yamllint disable-line rule:truthy | ||
on: [pull_request, push, workflow_dispatch] | ||
|
||
env: | ||
CMAKE_C_FLAGS: "-Werror -Wall -Wmissing-prototypes\ | ||
-Wimplicit-fallthrough=3 -Wpointer-arith" | ||
|
||
jobs: | ||
build-test: | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: {fetch-depth: 50, submodules: recursive} | ||
|
||
- name: install tools | ||
run: sudo apt update && sudo apt install -y ninja-build | ||
|
||
- name: build | ||
run: cmake -B build/ -G Ninja | ||
- run: cmake --build build/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you don't use $ref.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is passed into checkout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason I did this is otherwise it was giving me a merge which doesn't work for checkpatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct: by default
checkout
givespull/12355/merge
which is what most people want by default (even when they don't have a clue).BTW: https://github.com/thesofproject/sof/blob/main/.github/workflows/codestyle.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, ill look into that tomorrow, thanks for the pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a small repo, you should probably just do a
fetch :0
(= infinite). In case someone submits 51 rimage patches ;-)I wrote this code for the (huge) linux kernel initially but only ever tested on SOF (which does not really need it). Priorities...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, this just makes me want to write my own github action for this so we can maintain in one spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm someone did it, any issue if we just use this? https://github.com/marketplace/actions/checkpatch-pl-pr-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm someone did it, any issue if we just use this? https://github.com/marketplace/actions/checkpatch-pl-pr-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a look at it. The code wouldn't pass
shellcheck
but it's short, understandable and uses the right API (i.e.: NOTgit merge-base
Worth a try!