Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/compare_signed.bats: list all v2.4 and v2.5 reproducibility bugs #118

Merged
merged 1 commit into from
Mar 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion tests/compare_signed.bats
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,25 @@ test_init()
*v2.3.x/sof-v2.3)
assert_eq_signed $status 6;;

# work still in progress, see commit message 124ac3bd6ff1
# Comparing Zephyr binaries has been a challenge due to a few
# reproducibility bugs:

# - Confirmed cmake version difference affecting the linkage order, see
# sof commit: 157fd098ccd6 ("require cmake version 3.21.0 or above")

# - Potential git describe difference, see sof commit
# 09386bc0d978d Revert "xtensa-build-zephyr.py: west update --depth 5 --narrow"

# - 2017 xt-xcc toolchain bug triggered by length of source directory:
# https://github.com/thesofproject/sof/issues/7114

# The first two issues have been addressed in v2.5.

# The 2017 xt-xcc bug will never fixed. It comes and goes but is confirmed
# to affect v2.4.1 and v2.5. The west topdir length threshold is 27.5
# characters for v2.4.1 and 35.5 characters for v2.5. The west topdir length for
# community builds has usually been 46.

*v2.4.x/sof-v2.4.1)
assert_eq_signed $status 2;;

Expand Down