Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: alloc main buffer struct in the runtime shared zone #4696

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

abonislawski
Copy link
Member

Buffers can be shared between cores and it is crucial to have access
to not only proper buffer data but also description data of this buffer

Fixes #4648

Signed-off-by: Adrian Bonislawski adrian.bonislawski@intel.com

@cujomalainey
Copy link
Contributor

missing signed-off-by tag

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski I assume this has been validated on tgl13 ?

Buffers can be shared between cores and it is crucial to have access
to not only proper buffer data but also description data of this buffer

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
@abonislawski abonislawski force-pushed the fix_buffer_alloc_shared branch from e75f46c to 5e79c76 Compare August 30, 2021 15:32
@abonislawski
Copy link
Member Author

@abonislawski I assume this has been validated on tgl13 ?

@lgirdwood yes, tgl013 with some PRs from the description here:
#4648

@ranj063
Copy link
Collaborator

ranj063 commented Aug 30, 2021

@abonislawski this change is in the right direction but I don't think it is comprehensive but that's a separate topic altogether. I think we should merge this change to tgl-013 until we stress test multi-core on SOF main.

@lgirdwood
Copy link
Member

@abonislawski this change is in the right direction but I don't think it is comprehensive but that's a separate topic altogether. I think we should merge this change to tgl-013 until we stress test multi-core on SOF main.

Yeah, I think this is the correct hotfix required for tgl13, but long term we need to have a coherent API as it's not just buffers that will need to be shared (and we also want to use cache for performance).

@mwasko mwasko merged commit 6c17eba into thesofproject:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][TGL][Chrome] DSP Panic on opening Internal Mic after plugging/unplugging a headset
5 participants